Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable selecting (and copying) table name during table deletion confirmation #3307

Closed
dikwickley opened this issue Nov 14, 2023 · 4 comments
Labels
type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@dikwickley
Copy link

Problem

When deleting a table we have to write the table name in a text input to confirm deleting that table.
Currently, users can just select the table name and copy paste that in the text input.
Many websites having similar flow (eg vercel or github) disable selecting the name and also prevent pasting inside the text input.
image

Proposed solution

Prevent selecting the text inside the delete modal. Also disable pasting into the text input box.

@seancolsen seancolsen added work: frontend Related to frontend code in the mathesar_ui directory status: draft and removed status: triage labels Nov 14, 2023
@seancolsen seancolsen added this to the Backlog milestone Nov 14, 2023
@seancolsen
Copy link
Contributor

@dikwickley thanks for this suggestion.

I've labeled this ticket as status: draft for now though, indicating that it is not ready for implementation. I'm not sure we'll have agreement within our design team about whether or not we'd like to implement this. Our design team will take a look at update this ticket when we've made a decision. If we decide to move forward, we'll label this ticket with status: ready. If we decide this is not something we'd like to do, then we'll close this ticket.

@Tweniee
Copy link

Tweniee commented Nov 20, 2023

Suggestion:
I recommend disabling the ability to select and copy/paste text in the input field, as many applications follow this practice.

@shivansh-bhatnagar18
Copy link

Yeah, I agree with @Tweniee and @dikwickley on this that many organizations (such as GitHub itself) have implemented this functionality of not letting the user copy the repository name while deleting it which verifies that the user is in his full senses and additional security from mishaps

@seancolsen
Copy link
Contributor

We discussed this during today's product approval meeting and decided not to pursue this feature.

@seancolsen seancolsen closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants