Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linked record removal not being reflected after save #3308

Closed
ghislaineguerin opened this issue Nov 14, 2023 · 5 comments · Fixed by #3310
Closed

Linked record removal not being reflected after save #3308

ghislaineguerin opened this issue Nov 14, 2023 · 5 comments · Fixed by #3310
Assignees
@dikwickley
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Milestone
High priority

Comments

@ghislaineguerin
Copy link
Contributor

Description

When attempting to remove a linked record from the the record page it does not get removed as expected. Despite saving changes, the linked record reappears as if it had not been deleted.

Expected behavior

The deleted record should not reappear after saving changes.

To Reproduce

Remove a linked record from the record page view:
image
Save the changes:
image
Record is still there:
image
@ghislaineguerin ghislaineguerin added type: bug Something isn't working status: triage labels Nov 14, 2023
@seancolsen seancolsen added good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this work: frontend Related to frontend code in the mathesar_ui directory ready Ready for implementation and removed status: triage labels Nov 14, 2023
@seancolsen seancolsen added this to the High priority milestone Nov 14, 2023
@seancolsen
Copy link
Contributor

I'm able to reproduce this. It appears to be isolated to the front end. The request body that the front end sends to /api/db/v0/tables/<table_id>/records/<record_id>/ should contain an entry for the FK column. But instead the request body does not contain any entry for that column.

@dikwickley
Copy link

I would like to work on this. Please assign it to me.

@seancolsen
Copy link
Contributor

Sure @dikwickley, go ahead.

@dikwickley dikwickley mentioned this issue Nov 15, 2023
Merged
7 tasks
@As-ajay06
Copy link

I would like to work on this problem, can you assign me this problem.

@seancolsen
Copy link
Contributor

No @ajaySahani7945 this issue is closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dikwickley dikwickley

Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Status: Done
Milestone
High priority
Development

Successfully merging a pull request may close this issue.

Set clear value as null
4 participants
@seancolsen @ghislaineguerin @dikwickley @As-ajay06