Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front end changes for the "New Database Connection" form #3311

Closed
Tracked by #3294
seancolsen opened this issue Nov 17, 2023 · 5 comments · Fixed by #3319
Closed
Tracked by #3294

Front end changes for the "New Database Connection" form #3311

seancolsen opened this issue Nov 17, 2023 · 5 comments · Fixed by #3319
Assignees
Labels
ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@seancolsen
Copy link
Contributor

See these specs.

Case A Case B Case C
@seancolsen
Copy link
Contributor Author

I have a small design question about this feature. Not sure of the best place to ask, so I'm starting here. @ghislaineguerin @pavish @kgodey @mathemancer I'm tagging you to see if you want to weigh in with your opinion.

After a user adds a new connection, what should happen next?

  • (A) close the modal, showing the table of all connections.

    We follow this pattern when creating new schemas. It would be the easiest to implement.

    This is potentially annoying if there are already lots of connections though. It's not necessarily easy to find the one you just added.

  • (B) same as (A), but also highlight the new connection.

    We don't think we follow this pattern anywhere.

    We could highlight the new one, but doing this well would be slightly complex (I can explain more if needed). This would be the hardest to implement of all the options.

  • (C) navigate to the Database Page for the connection

    We follow this pattern when creating new tables because we navigate to the table.

    This is probably what most users would want, and it would be very easy to implement.

    I'm leaning towards this.

  • (D) give the user a choice

    We don't follow this pattern anywhere, but for the Add Record page (yet to be implemented) it's important to me that we do establish a pattern like this.

    Here's an example of what this could look like for the New Connection modal:

    In the footer, we'd have this select input which would default to "Open", meaning that Mathesar would navigate to the Database Page for that connection. I like this pattern because I think it gives users a clearer expectation of the next step and it allows them to quickly add several connections in sequence.

    This would be relatively easy to implement.

@ghislaineguerin
Copy link
Contributor

@seancolsen I'm also leaning towards option C. I think option D makes sense for the "Add Record Page" but not sure if needed for connections, since adding multiple seems unlikely.

@seancolsen
Copy link
Contributor Author

Sounds good, @ghislaineguerin. I'll go with that unless anyone else wants to voice other opinions.

@pavish
Copy link
Member

pavish commented Dec 18, 2023

@seancolsen I also think C is the best option.

@kgodey
Copy link
Contributor

kgodey commented Dec 18, 2023

+1 to option C.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants