Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLAlchemy filters still in codebase #3424

Closed
mathemancer opened this issue Jan 29, 2024 · 0 comments · Fixed by #3425
Closed

SQLAlchemy filters still in codebase #3424

mathemancer opened this issue Jan 29, 2024 · 0 comments · Fixed by #3425
Assignees
@mathemancer
Labels
priority: urgent Blocks other ongoing work ready Ready for implementation type: bug Something isn't working work: backend Related to Python, Django, and simple SQL
Milestone
v0.1.4

Comments

@mathemancer
Copy link
Contributor

mathemancer commented Jan 29, 2024 •
edited
Loading

Description

sqlalchemy-filters is required in parts of our codebase, but was removed from requirements.txt.

Expected behavior

Only one of the above should be true

Additional context

@kgodey crashed into this while doing the build from scratch docs.

Related issue: #3314
Related PR: #3317

Basically, that PR removed SQLAlchemy from requirements.txt, but not all spots of the codebase. The reason we didn't find this issue until now is that we do all testing on Docker, and the relevant Dockerfile includes an explicit instruction to install sqlalchemy-filters aside from the requirements.txt.
@mathemancer mathemancer added type: bug Something isn't working work: backend Related to Python, Django, and simple SQL ready Ready for implementation priority: urgent Blocks other ongoing work labels Jan 29, 2024
@mathemancer mathemancer self-assigned this Jan 29, 2024
@mathemancer mathemancer mentioned this issue Jan 29, 2024
Merged
7 tasks
@mathemancer mathemancer added this to the v0.1.4 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathemancer mathemancer

Labels
priority: urgent Blocks other ongoing work ready Ready for implementation type: bug Something isn't working work: backend Related to Python, Django, and simple SQL
Projects
None yet
Milestone
v0.1.4
Development

Successfully merging a pull request may close this issue.

remove remaining SQLAlchemy filters dependencies mathesar-foundation/mathesar
1 participant
@mathemancer