Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tables and columns properties to RPC joinable_tables API #3713

Closed
seancolsen opened this issue Jul 30, 2024 · 2 comments · Fixed by #3718
Closed

Add tables and columns properties to RPC joinable_tables API #3713

seancolsen opened this issue Jul 30, 2024 · 2 comments · Fixed by #3718
Assignees
Labels
ready Ready for implementation type: bug Something isn't working work: backend Related to Python, Django, and simple SQL

Comments

@seancolsen
Copy link
Contributor

In the REST API, the joinable_tables API returned an object like this:

{
  "joinable_tables": [
    // ...
  ],
  "tables": [
    // ...
  ],
  "columns": [
    // ...
  ],
}

The corresponding RPC API only returns an array of joinable table objects.

The front end needs the tables and columns properties too. Can we please add those back?

@seancolsen seancolsen added ready Ready for implementation type: bug Something isn't working work: backend Related to Python, Django, and simple SQL labels Jul 30, 2024
@seancolsen seancolsen added this to the Beta milestone Jul 30, 2024
@Anish9901
Copy link
Member

@seancolsen
Instead of having tables and columns separate are you okay if its combined?

Before

{
  "tables": {
    "10": {
      "name": "Authors",
      "columns": [1, 2, 26]
    }
  },
  "columns": {
    "1" : {"name": "First Name", "type": "text"   },
    "2" : {"name": "Last Name" , "type": "text"   },
    "26": {"name": "id"        , "type": "integer"}
  }
}

After

"tables": {
  "10": {
    "name": "Authors",
    "columns": {
        "1" : {"name": "First Name", "type": "text"   },
        "2" : {"name": "Last Name" , "type": "text"   },
        "26": {"name": "id"        , "type": "integer"}
     }
  }
}

@seancolsen
Copy link
Contributor Author

are you okay if its combined?

I replied in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation type: bug Something isn't working work: backend Related to Python, Django, and simple SQL
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants