From 0db9a9e1ccb27d0a3a59eed460f8488fa3b3d943 Mon Sep 17 00:00:00 2001 From: Scott Estabrook Date: Tue, 13 Aug 2024 09:38:58 -0400 Subject: [PATCH 01/10] Adding codecov build, updated to main --- .github/workflows/build_and_test_codecov.yml | 62 ++++++++++++++++++++ codecov.yml | 10 ++++ 2 files changed, 72 insertions(+) create mode 100644 .github/workflows/build_and_test_codecov.yml create mode 100644 codecov.yml diff --git a/.github/workflows/build_and_test_codecov.yml b/.github/workflows/build_and_test_codecov.yml new file mode 100644 index 0000000..bfcbea4 --- /dev/null +++ b/.github/workflows/build_and_test_codecov.yml @@ -0,0 +1,62 @@ +name: "OpenTelemetry-Matlab" +on: + workflow_dispatch: + push: +env: + MLM_LICENSE_TOKEN: ${{ secrets.MLM_LICENSE_TOKEN }} +jobs: + get_version: + runs-on: ubuntu-20.04 + outputs: + version: ${{ steps.getversion.outputs.latest_tag }} + steps: + # need fetch-depth:0 to also download the tags + - name: Download OpenTelemetry-Matlab source + uses: actions/checkout@v3 + with: + path: opentelemetry-matlab + fetch-depth: 0 + - name: Get Version + id: getversion + shell: bash + working-directory: opentelemetry-matlab + run: echo "latest_tag=$(sed -re 's/^v?([[:digit:]]+\.[[:digit:]]+\.[[:digit:]]+)?.*/\1/' <<< $(git describe --tags --abbrev=0))" >> $GITHUB_OUTPUT + codecov-ubuntu: + # Running on ubuntu-latest would use a glibc version that is incompatible when using the built mex files on a Debian 11 + # Instead, run on ubuntu-20.04 + runs-on: ubuntu-20.04 + needs: get_version + env: + OPENTELEMETRY_MATLAB_INSTALL: "${{ github.workspace }}/otel_matlab_install" + SYSTEM_LIBSTDCPP_PATH: "/usr/lib/x86_64-linux-gnu/libstdc++.so.6" + steps: + - name: Download OpenTelemetry-Matlab source + uses: actions/checkout@v3 + with: + path: opentelemetry-matlab + - name: Install ninja-build + run: sudo apt-get install ninja-build + - name: Install MATLAB + uses: matlab-actions/setup-matlab@v2 + with: + products: MATLAB_Compiler MATLAB_Compiler_SDK + - name: Build OpenTelemetry-Matlab + working-directory: opentelemetry-matlab + run: | + cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DWITH_EXAMPLES=ON -DUSE_BATCH_FOR_MCC=ON -DOTEL_MATLAB_VERSION=${{ needs.get_version.outputs.version }} -DCMAKE_INSTALL_PREFIX=${{ env.OPENTELEMETRY_MATLAB_INSTALL }} + cmake --build build --config Release --target install + - name: Get Codecov + env: + # Add the installation directory to the MATLAB Search Path by + # setting the MATLABPATH environment variable. + MATLABPATH: ${{ env.OPENTELEMETRY_MATLAB_INSTALL }} + uses: matlab-actions/run-tests@v2 + with: + source-folder: ${{ env.OPENTELEMETRY_MATLAB_INSTALL }} + code-coverage-cobertura: cobertura.xml + - name: Upload Codecov + uses: codecov/codecov-action@v4 + with: + token: ${{ secrets.CODECOV_TOKEN }} + slug: mathworks/OpenTelemetry-Matlab + file: cobertura.xml \ No newline at end of file diff --git a/codecov.yml b/codecov.yml new file mode 100644 index 0000000..4fd5a64 --- /dev/null +++ b/codecov.yml @@ -0,0 +1,10 @@ +fixes: + - "+opentelemetry/+sdk/+trace/::sdk/trace/+opentelemetry/+sdk/+trace/" + - "+opentelemetry/+sdk/+metrics/::sdk/trace/+opentelemetry/+sdk/+metrics/" + - "+opentelemetry/+sdk/+common/::sdk/metrics/+opentelemetry/+sdk/+common/" + - "+opentelemetry/+trace/::api/metrics/+opentelemetry/+trace/" + - "+opentelemetry/+metrics/::api/metrics/+opentelemetry/+metrics/" + - "+opentelemetry/+context/::api/metrics/+opentelemetry/+context/" + - "+opentelemetry/+common/::api/metrics/+opentelemetry/+common/" + - "+opentelemetry/+baggage/::api/metrics/+opentelemetry/+baggage/" + - "+opentelemetry/+exporters/+otlp/::exporters/otlp/+opentelemetry/+exporters/+otlp/" \ No newline at end of file From 5f6180678d9ccae3fe2866835e7a2575e12e85a1 Mon Sep 17 00:00:00 2001 From: Scott Estabrook Date: Tue, 13 Aug 2024 10:32:40 -0400 Subject: [PATCH 02/10] Update codecov.yml fixes --- codecov.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/codecov.yml b/codecov.yml index 4fd5a64..6c61b50 100644 --- a/codecov.yml +++ b/codecov.yml @@ -1,10 +1,10 @@ fixes: - "+opentelemetry/+sdk/+trace/::sdk/trace/+opentelemetry/+sdk/+trace/" - - "+opentelemetry/+sdk/+metrics/::sdk/trace/+opentelemetry/+sdk/+metrics/" - - "+opentelemetry/+sdk/+common/::sdk/metrics/+opentelemetry/+sdk/+common/" - - "+opentelemetry/+trace/::api/metrics/+opentelemetry/+trace/" + - "+opentelemetry/+sdk/+metrics/::sdk/metrics/+opentelemetry/+sdk/+metrics/" + - "+opentelemetry/+sdk/+common/::sdk/common/+opentelemetry/+sdk/+common/" + - "+opentelemetry/+trace/::api/trace/+opentelemetry/+trace/" - "+opentelemetry/+metrics/::api/metrics/+opentelemetry/+metrics/" - - "+opentelemetry/+context/::api/metrics/+opentelemetry/+context/" - - "+opentelemetry/+common/::api/metrics/+opentelemetry/+common/" - - "+opentelemetry/+baggage/::api/metrics/+opentelemetry/+baggage/" + - "+opentelemetry/+context/::api/context/+opentelemetry/+context/" + - "+opentelemetry/+common/::api/common/+opentelemetry/+common/" + - "+opentelemetry/+baggage/::api/baggage/+opentelemetry/+baggage/" - "+opentelemetry/+exporters/+otlp/::exporters/otlp/+opentelemetry/+exporters/+otlp/" \ No newline at end of file From 5d1d7274bbc2a5dee40dd11cf2124c4094327181 Mon Sep 17 00:00:00 2001 From: Scott Estabrook Date: Thu, 15 Aug 2024 09:37:11 -0400 Subject: [PATCH 03/10] running code coverage without path fixes --- codecov.yml | 10 ---------- 1 file changed, 10 deletions(-) delete mode 100644 codecov.yml diff --git a/codecov.yml b/codecov.yml deleted file mode 100644 index 6c61b50..0000000 --- a/codecov.yml +++ /dev/null @@ -1,10 +0,0 @@ -fixes: - - "+opentelemetry/+sdk/+trace/::sdk/trace/+opentelemetry/+sdk/+trace/" - - "+opentelemetry/+sdk/+metrics/::sdk/metrics/+opentelemetry/+sdk/+metrics/" - - "+opentelemetry/+sdk/+common/::sdk/common/+opentelemetry/+sdk/+common/" - - "+opentelemetry/+trace/::api/trace/+opentelemetry/+trace/" - - "+opentelemetry/+metrics/::api/metrics/+opentelemetry/+metrics/" - - "+opentelemetry/+context/::api/context/+opentelemetry/+context/" - - "+opentelemetry/+common/::api/common/+opentelemetry/+common/" - - "+opentelemetry/+baggage/::api/baggage/+opentelemetry/+baggage/" - - "+opentelemetry/+exporters/+otlp/::exporters/otlp/+opentelemetry/+exporters/+otlp/" \ No newline at end of file From 5b682e3980d696ef7a34a99214a20c3049f76c38 Mon Sep 17 00:00:00 2001 From: Scott Estabrook Date: Thu, 15 Aug 2024 10:10:44 -0400 Subject: [PATCH 04/10] codecov having issues with upload, try ignoring .test files showing up when attempting to upload coverage --- codecov.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 codecov.yml diff --git a/codecov.yml b/codecov.yml new file mode 100644 index 0000000..a753d0b --- /dev/null +++ b/codecov.yml @@ -0,0 +1,2 @@ +ignore: + - "**/*.test" \ No newline at end of file From 42eb313a5a1ef8304061ea2b7116fd6e0599e60e Mon Sep 17 00:00:00 2001 From: Scott Estabrook Date: Thu, 15 Aug 2024 10:49:05 -0400 Subject: [PATCH 05/10] run codecov with fixes --- codecov.yml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/codecov.yml b/codecov.yml index a753d0b..6c6bae6 100644 --- a/codecov.yml +++ b/codecov.yml @@ -1,2 +1,12 @@ ignore: - - "**/*.test" \ No newline at end of file + - "**/*.test" +fixes: + - "+opentelemetry/+sdk/+trace/::sdk/trace/+opentelemetry/+sdk/+trace/" + - "+opentelemetry/+sdk/+metrics/::sdk/metrics/+opentelemetry/+sdk/+metrics/" + - "+opentelemetry/+sdk/+common/::sdk/common/+opentelemetry/+sdk/+common/" + - "+opentelemetry/+trace/::api/trace/+opentelemetry/+trace/" + - "+opentelemetry/+metrics/::api/metrics/+opentelemetry/+metrics/" + - "+opentelemetry/+context/::api/context/+opentelemetry/+context/" + - "+opentelemetry/+common/::api/common/+opentelemetry/+common/" + - "+opentelemetry/+baggage/::api/baggage/+opentelemetry/+baggage/" + - "+opentelemetry/+exporters/+otlp/::exporters/otlp/+opentelemetry/+exporters/+otlp/" \ No newline at end of file From 5ddb65f59187ae79f8e22c7553d10900cb57dd96 Mon Sep 17 00:00:00 2001 From: Scott Estabrook Date: Thu, 15 Aug 2024 11:39:25 -0400 Subject: [PATCH 06/10] add regex fixes for + in filepaths --- codecov.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/codecov.yml b/codecov.yml index 6c6bae6..29ad1d0 100644 --- a/codecov.yml +++ b/codecov.yml @@ -1,12 +1,12 @@ ignore: - "**/*.test" fixes: - - "+opentelemetry/+sdk/+trace/::sdk/trace/+opentelemetry/+sdk/+trace/" - - "+opentelemetry/+sdk/+metrics/::sdk/metrics/+opentelemetry/+sdk/+metrics/" - - "+opentelemetry/+sdk/+common/::sdk/common/+opentelemetry/+sdk/+common/" - - "+opentelemetry/+trace/::api/trace/+opentelemetry/+trace/" - - "+opentelemetry/+metrics/::api/metrics/+opentelemetry/+metrics/" - - "+opentelemetry/+context/::api/context/+opentelemetry/+context/" - - "+opentelemetry/+common/::api/common/+opentelemetry/+common/" - - "+opentelemetry/+baggage/::api/baggage/+opentelemetry/+baggage/" - - "+opentelemetry/+exporters/+otlp/::exporters/otlp/+opentelemetry/+exporters/+otlp/" \ No newline at end of file + - "\\+opentelemetry/\\+sdk/\\+trace/::sdk/trace/\\+opentelemetry/\\+sdk/\\+trace/" + - "\\+opentelemetry/\\+sdk/\\+metrics/::sdk/metrics/\\+opentelemetry/\\+sdk/\\+metrics/" + - "\\+opentelemetry/\\+sdk/\\+common/::sdk/common/\\+opentelemetry/\\+sdk/\\+common/" + - "\\+opentelemetry/\\+trace/::api/trace/\\+opentelemetry/\\+trace/" + - "\\+opentelemetry/\\+metrics/::api/metrics/\\+opentelemetry/\\+metrics/" + - "\\+opentelemetry/\\+context/::api/context/\\+opentelemetry/\\+context/" + - "\\+opentelemetry/\\+common/::api/common/\\+opentelemetry/\\+common/" + - "\\+opentelemetry/\\+baggage/::api/baggage/\\+opentelemetry/\\+baggage/" + - "\\+opentelemetry/\\+exporters/\\+otlp/::exporters/otlp/\\+opentelemetry/\\+exporters/\\+otlp/" \ No newline at end of file From aae9b1c321e6725d44e21df612430e132dcba41d Mon Sep 17 00:00:00 2001 From: Scott Estabrook Date: Thu, 15 Aug 2024 13:40:38 -0400 Subject: [PATCH 07/10] update regex for fixes --- codecov.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/codecov.yml b/codecov.yml index 29ad1d0..1fdeb3f 100644 --- a/codecov.yml +++ b/codecov.yml @@ -1,12 +1,12 @@ ignore: - "**/*.test" fixes: - - "\\+opentelemetry/\\+sdk/\\+trace/::sdk/trace/\\+opentelemetry/\\+sdk/\\+trace/" - - "\\+opentelemetry/\\+sdk/\\+metrics/::sdk/metrics/\\+opentelemetry/\\+sdk/\\+metrics/" - - "\\+opentelemetry/\\+sdk/\\+common/::sdk/common/\\+opentelemetry/\\+sdk/\\+common/" - - "\\+opentelemetry/\\+trace/::api/trace/\\+opentelemetry/\\+trace/" - - "\\+opentelemetry/\\+metrics/::api/metrics/\\+opentelemetry/\\+metrics/" - - "\\+opentelemetry/\\+context/::api/context/\\+opentelemetry/\\+context/" - - "\\+opentelemetry/\\+common/::api/common/\\+opentelemetry/\\+common/" - - "\\+opentelemetry/\\+baggage/::api/baggage/\\+opentelemetry/\\+baggage/" - - "\\+opentelemetry/\\+exporters/\\+otlp/::exporters/otlp/\\+opentelemetry/\\+exporters/\\+otlp/" \ No newline at end of file + - "\\+opentelemetry/\\+sdk/\\+trace/::sdk/trace/+opentelemetry/+sdk/+trace/" + - "\\+opentelemetry/\\+sdk/\\+metrics/::sdk/metrics/+opentelemetry/+sdk/+metrics/" + - "\\+opentelemetry/\\+sdk/\\+common/::sdk/common/+opentelemetry/+sdk/+common/" + - "\\+opentelemetry/\\+trace/::api/trace/+opentelemetry/+trace/" + - "\\+opentelemetry/\\+metrics/::api/metrics/+opentelemetry/+metrics/" + - "\\+opentelemetry/\\+context/::api/context/+opentelemetry/+context/" + - "\\+opentelemetry/\\+common/::api/common/+opentelemetry/+common/" + - "\\+opentelemetry/\\+baggage/::api/baggage/+opentelemetry/+baggage/" + - "\\+opentelemetry/\\+exporters/\\+otlp/::exporters/otlp/+opentelemetry/+exporters/+otlp/" \ No newline at end of file From f0767d762218d55d48f69c5493da17dc8eaaa187 Mon Sep 17 00:00:00 2001 From: Scott Estabrook Date: Thu, 15 Aug 2024 14:41:53 -0400 Subject: [PATCH 08/10] Add codecov badge to testing README, update codecov.yml to include remaining paths, rename code coverage job --- .github/workflows/build_and_test_codecov.yml | 2 +- README.md | 2 +- codecov.yml | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build_and_test_codecov.yml b/.github/workflows/build_and_test_codecov.yml index bfcbea4..a7dfe84 100644 --- a/.github/workflows/build_and_test_codecov.yml +++ b/.github/workflows/build_and_test_codecov.yml @@ -1,4 +1,4 @@ -name: "OpenTelemetry-Matlab" +name: "Code Coverage" on: workflow_dispatch: push: diff --git a/README.md b/README.md index 8f2ca26..7c4b6a2 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,5 @@ # MATLAB Interface to OpenTelemetry -[![View OpenTelemetry-Matlab on File Exchange](https://www.mathworks.com/matlabcentral/images/matlab-file-exchange.svg)](https://www.mathworks.com/matlabcentral/fileexchange/130979-opentelemetry-matlab) [![MATLAB](https://github.com/mathworks/OpenTelemetry-Matlab/actions/workflows/build_and_test_full.yml/badge.svg)](https://github.com/mathworks/OpenTelemetry-Matlab/actions/workflows/build_and_test_full.yml) +[![View OpenTelemetry-Matlab on File Exchange](https://www.mathworks.com/matlabcentral/images/matlab-file-exchange.svg)](https://www.mathworks.com/matlabcentral/fileexchange/130979-opentelemetry-matlab) [![MATLAB](https://github.com/mathworks/OpenTelemetry-Matlab/actions/workflows/build_and_test_full.yml/badge.svg)](https://github.com/mathworks/OpenTelemetry-Matlab/actions/workflows/build_and_test_full.yml) [![codecov](https://codecov.io/github/mathworks/OpenTelemetry-MATLAB/branch/testing/graph/badge.svg?token=VNj6f1LlMG)](https://codecov.io/github/mathworks/OpenTelemetry-MATLAB) MATLAB® interface to [OpenTelemetry™](https://opentelemetry.io/), based on the [OpenTelemetry Specification](https://opentelemetry.io/docs/specs/otel/). OpenTelemetry is an observability framework for creating and managing telemetry data, such as traces, metrics, and logs. This data can then be sent to an observability back-end for monitoring, alerts, and analysis. diff --git a/codecov.yml b/codecov.yml index 1fdeb3f..a1b7d42 100644 --- a/codecov.yml +++ b/codecov.yml @@ -9,4 +9,6 @@ fixes: - "\\+opentelemetry/\\+context/::api/context/+opentelemetry/+context/" - "\\+opentelemetry/\\+common/::api/common/+opentelemetry/+common/" - "\\+opentelemetry/\\+baggage/::api/baggage/+opentelemetry/+baggage/" - - "\\+opentelemetry/\\+exporters/\\+otlp/::exporters/otlp/+opentelemetry/+exporters/+otlp/" \ No newline at end of file + - "\\+opentelemetry/\\+exporters/\\+otlp/::exporters/otlp/+opentelemetry/+exporters/+otlp/" + - "\\+opentelemetry/\\+sdk/\\+logs::sdk/logs/+opentelemetry/+sdk/+logs/" + - "\\+opentelemetry/\\+logs/::api/logs/+opentelemetry/+logs/"s \ No newline at end of file From 7bf4ac4e693fe54a49500e835e8b5cdb997dc8e6 Mon Sep 17 00:00:00 2001 From: Scott Estabrook Date: Tue, 3 Sep 2024 14:53:24 -0400 Subject: [PATCH 09/10] update testing with main, move code coverage to build_and_test_full --- .github/workflows/build_and_test_full.yml | 40 +++++++++++++++++++++++ README.md | 2 +- codecov.yml | 14 ++++++++ 3 files changed, 55 insertions(+), 1 deletion(-) create mode 100644 codecov.yml diff --git a/.github/workflows/build_and_test_full.yml b/.github/workflows/build_and_test_full.yml index b417494..179ebb6 100644 --- a/.github/workflows/build_and_test_full.yml +++ b/.github/workflows/build_and_test_full.yml @@ -5,6 +5,7 @@ on: push: branches: - main + - testing env: MLM_LICENSE_TOKEN: ${{ secrets.MLM_LICENSE_TOKEN }} jobs: @@ -56,6 +57,45 @@ jobs: uses: matlab-actions/run-tests@v2 with: select-by-folder: opentelemetry-matlab/test + code-coverage-build-and-run-tests-ubuntu: + # Running on ubuntu-latest would use a glibc version that is incompatible when using the built mex files on a Debian 11 + # Instead, run on ubuntu-20.04 + runs-on: ubuntu-20.04 + needs: get_version + env: + OPENTELEMETRY_MATLAB_INSTALL: "${{ github.workspace }}/otel_matlab_install" + SYSTEM_LIBSTDCPP_PATH: "/usr/lib/x86_64-linux-gnu/libstdc++.so.6" + steps: + - name: Download OpenTelemetry-Matlab source + uses: actions/checkout@v3 + with: + path: opentelemetry-matlab + - name: Install ninja-build + run: sudo apt-get install ninja-build + - name: Install MATLAB + uses: matlab-actions/setup-matlab@v2 + with: + products: MATLAB_Compiler MATLAB_Compiler_SDK + - name: Build OpenTelemetry-Matlab + working-directory: opentelemetry-matlab + run: | + cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DWITH_EXAMPLES=ON -DWITH_OTLP_GRPC=ON -DUSE_BATCH_FOR_MCC=ON -DOTEL_MATLAB_VERSION=${{ needs.get_version.outputs.version }} -DCMAKE_INSTALL_PREFIX=${{ env.OPENTELEMETRY_MATLAB_INSTALL }} + cmake --build build --config Release --target install + - name: Run tests & get coverage + env: + # Add the installation directory to the MATLAB Search Path by + # setting the MATLABPATH environment variable. + MATLABPATH: ${{ env.OPENTELEMETRY_MATLAB_INSTALL }} + uses: matlab-actions/run-tests@v2 + with: + source-folder: ${{ env.OPENTELEMETRY_MATLAB_INSTALL }} + code-coverage-cobertura: cobertura.xml + - name: Upload Codecov + uses: codecov/codecov-action@v4 + with: + token: ${{ secrets.CODECOV_TOKEN }} + slug: mathworks/OpenTelemetry-Matlab + file: cobertura.xml build-and-run-tests-windows: runs-on: windows-latest needs: get_version diff --git a/README.md b/README.md index 8f2ca26..561f68f 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,5 @@ # MATLAB Interface to OpenTelemetry -[![View OpenTelemetry-Matlab on File Exchange](https://www.mathworks.com/matlabcentral/images/matlab-file-exchange.svg)](https://www.mathworks.com/matlabcentral/fileexchange/130979-opentelemetry-matlab) [![MATLAB](https://github.com/mathworks/OpenTelemetry-Matlab/actions/workflows/build_and_test_full.yml/badge.svg)](https://github.com/mathworks/OpenTelemetry-Matlab/actions/workflows/build_and_test_full.yml) +[![View OpenTelemetry-Matlab on File Exchange](https://www.mathworks.com/matlabcentral/images/matlab-file-exchange.svg)](https://www.mathworks.com/matlabcentral/fileexchange/130979-opentelemetry-matlab) [![MATLAB](https://github.com/mathworks/OpenTelemetry-Matlab/actions/workflows/build_and_test_full.yml/badge.svg)](https://github.com/mathworks/OpenTelemetry-Matlab/actions/workflows/build_and_test_full.yml)[![codecov](https://codecov.io/github/mathworks/OpenTelemetry-MATLAB/graph/badge.svg?token=VNj6f1LlMG)](https://codecov.io/github/mathworks/OpenTelemetry-MATLAB) MATLAB® interface to [OpenTelemetry™](https://opentelemetry.io/), based on the [OpenTelemetry Specification](https://opentelemetry.io/docs/specs/otel/). OpenTelemetry is an observability framework for creating and managing telemetry data, such as traces, metrics, and logs. This data can then be sent to an observability back-end for monitoring, alerts, and analysis. diff --git a/codecov.yml b/codecov.yml new file mode 100644 index 0000000..e16f6b0 --- /dev/null +++ b/codecov.yml @@ -0,0 +1,14 @@ +ignore: + - "**/*.test" +fixes: + - "\\+opentelemetry/\\+sdk/\\+trace/::sdk/trace/+opentelemetry/+sdk/+trace/" + - "\\+opentelemetry/\\+sdk/\\+metrics/::sdk/metrics/+opentelemetry/+sdk/+metrics/" + - "\\+opentelemetry/\\+sdk/\\+common/::sdk/common/+opentelemetry/+sdk/+common/" + - "\\+opentelemetry/\\+trace/::api/trace/+opentelemetry/+trace/" + - "\\+opentelemetry/\\+metrics/::api/metrics/+opentelemetry/+metrics/" + - "\\+opentelemetry/\\+context/::api/context/+opentelemetry/+context/" + - "\\+opentelemetry/\\+common/::api/common/+opentelemetry/+common/" + - "\\+opentelemetry/\\+baggage/::api/baggage/+opentelemetry/+baggage/" + - "\\+opentelemetry/\\+exporters/\\+otlp/::exporters/otlp/+opentelemetry/+exporters/+otlp/" + - "\\+opentelemetry/\\+sdk/\\+logs::sdk/logs/+opentelemetry/+sdk/+logs/" + - "\\+opentelemetry/\\+logs/::api/logs/+opentelemetry/+logs/" \ No newline at end of file From d4be55b37492fb6cb19514b175a029a141a2bff2 Mon Sep 17 00:00:00 2001 From: Scott Estabrook <124709205+MWSestabro@users.noreply.github.com> Date: Wed, 4 Sep 2024 14:24:14 -0400 Subject: [PATCH 10/10] Update build_and_test_full.yml to address PR feedback --- .github/workflows/build_and_test_full.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/build_and_test_full.yml b/.github/workflows/build_and_test_full.yml index 179ebb6..da77a23 100644 --- a/.github/workflows/build_and_test_full.yml +++ b/.github/workflows/build_and_test_full.yml @@ -5,7 +5,6 @@ on: push: branches: - main - - testing env: MLM_LICENSE_TOKEN: ${{ secrets.MLM_LICENSE_TOKEN }} jobs: @@ -47,7 +46,7 @@ jobs: - name: Build OpenTelemetry-Matlab working-directory: opentelemetry-matlab run: | - cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DWITH_EXAMPLES=ON -DWITH_OTLP_GRPC=ON -DUSE_BATCH_FOR_MCC=ON -DOTEL_MATLAB_VERSION=${{ needs.get_version.outputs.version }} -DCMAKE_INSTALL_PREFIX=${{ env.OPENTELEMETRY_MATLAB_INSTALL }} + cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DWITH_EXAMPLES=ON -DWITH_OTLP_GRPC=ON -DWITH_OTLP_FILE=ON -DUSE_BATCH_FOR_MCC=ON -DOTEL_MATLAB_VERSION=${{ needs.get_version.outputs.version }} -DCMAKE_INSTALL_PREFIX=${{ env.OPENTELEMETRY_MATLAB_INSTALL }} cmake --build build --config Release --target install - name: Run tests env: