Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed BaseAnnotationTool updates #21

Open
rjackey opened this issue Feb 15, 2023 · 2 comments
Open

Proposed BaseAnnotationTool updates #21

rjackey opened this issue Feb 15, 2023 · 2 comments
Assignees

Comments

@rjackey
Copy link
Member

rjackey commented Feb 15, 2023

o +wt+tool+BaseAnnotationTool.m - I made significant updates to isClickableAxes() to resolve cases where the mouse pointer did not properly detect whether it was over a valid axes or not; in onMousePress_private() and onMouseRelease_private() and onMouseMotion_private() I use either obj.ClickableAxes.CurrentPoint when e.intersectionPoint is all nans (happens near the edge of the axes, outside the clipping area);

rjackey pushed a commit that referenced this issue Feb 17, 2023
…es to isClickableAxes() to resolve cases where the mouse pointer did not properly detect whether it was over a valid axes or not; in onMousePress_private() and onMouseRelease_private() and onMouseMotion_private() I use either obj.ClickableAxes.CurrentPoint when e.intersectionPoint is all nans (happens near the edge of the axes, outside the clipping area);
@rjackey rjackey self-assigned this Feb 17, 2023
@rjackey
Copy link
Member Author

rjackey commented Feb 17, 2023

@altmany I have merged in the changes that appear to be generic. I think it would be useful to have a way to insert a custom filter for mouse actions. That may help in customer-specific use cases where we want to ignore the mouse actions based on the hit part of the drawing. Maybe additional properties of type function_handle that must return a true/false, then if populated the callbacks would exit early?

If you'd like to go ahead with that change, I would prefer if you can propose what's needed here and send me code or submit updates directly.

@rjackey
Copy link
Member Author

rjackey commented Feb 23, 2023

I had to back out some changes due to issues.

For example, it allowed me to place vertices outside of the image stack. I assume that is not intended?
image

image

rjackey pushed a commit that referenced this issue Feb 23, 2023
…tices placement or dragging outside of the data area of the axes during volume stack labeling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant