Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultContentNegotiator should support wildcards #52

Open
asarkar opened this issue Jun 22, 2014 · 8 comments
Open

DefaultContentNegotiator should support wildcards #52

asarkar opened this issue Jun 22, 2014 · 8 comments

Comments

@asarkar
Copy link
Contributor

asarkar commented Jun 22, 2014

When the Accept header contains wildcard /, DefaultContentNegotiator should not try a literal match but return EQUAL instead.

@matiwinnetou
Copy link
Owner

Works like a charm, tested on curl

@asarkar
Copy link
Contributor Author

asarkar commented Jun 22, 2014

Thanks. I was in a dilemma if there's any need to support wildcard because people depending on the Accept header should specify one anyway. But it seemed like the right thing to do.
Let me know when you release it so that we can start using the latest version in our project.

@matiwinnetou
Copy link
Owner

I can make a release. It would be appreciated if you test this in your environment. I am in a totally different project now, away from servlet container like tomcat and using Play so cannot test this apart from playing with example project at home. If there is a bug, we can still release a bug fix later.

@asarkar
Copy link
Contributor Author

asarkar commented Jun 22, 2014

We can do that, shouldn't be a problem.

@matiwinnetou
Copy link
Owner

Are you guys also using ajax-compiler module? I am releasing now 1.25.4...

@matiwinnetou
Copy link
Owner

Released, will be synced to maven central within a few hours.
https://oss.sonatype.org/content/repositories/releases/pl/matisoft/spring-soy-view/1.25.4/

@asarkar
Copy link
Contributor Author

asarkar commented Jun 22, 2014

We're not using the ajax compiler AFAIK.

@matiwinnetou
Copy link
Owner

Maven central sync complete:

http://repo1.maven.org/maven2/pl/matisoft/spring-soy-view/1.25.4/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants