Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify name of placeholder icon and use proper icon instead of empty png. #11

Open
Findus23 opened this issue May 10, 2017 · 3 comments
Open

Comments

@Findus23
Copy link
Member

At the moment the placeholder icon (Transparent png) has multiple different names, which is bugging me for some time.

placeholder_icon_filenames = {
    "brand": "unk.png",
    "browsers": "UNK.png",
    "devices": "unknown.png",
    "os": "UNK.png",
    "searchEngines": "xx.png",
    "socials": "xx.png"
}

It would be nice to rename them to one common name (e.g. unk.png).

This also needs to be changed in Piwik (functions for generating icon path and in tests) and in the ReferrersManager-Plugin (see sgiehl/piwik-plugin-ReferrersManager#11)

@sgiehl
Copy link
Member

sgiehl commented May 10, 2017

We should consider replacing the empty images with maybe something else like a question mark or so.
We currently have some places where we show overlays when hovering the images (e.g. in visitor log). Having an empty image makes it difficult to see there is something that can be hovered.

We could also look for good images representing something "unknown" for each type, but maybe that isn't really needed.

@Findus23
Copy link
Member Author

That's a great idea. I'll definitely do this.

representing something "unknown" for each type

While I would really like this, I'm not sure if I'm able to create nice looking ones. Maybe someone who is better at designing than me could help.

@Findus23 Findus23 changed the title Unify name of placeholder icon Unify name of placeholder icon and use proper icon instead of empty png. Sep 26, 2018
@Findus23
Copy link
Member Author

BTW: There is already a proper icon for an unknown flag, so maybe we could create similar ones for the rest:
https://github.com/matomo-org/matomo-icons/blob/master/unk.flag.svg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants