Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various TODO's in the code #153

Open
6 of 15 tasks
jgallowa07 opened this issue Apr 1, 2024 · 0 comments
Open
6 of 15 tasks

Various TODO's in the code #153

jgallowa07 opened this issue Apr 1, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jgallowa07
Copy link
Member

jgallowa07 commented Apr 1, 2024

I have a small litany of things I noticed during the last few PR's that I didn't want to get side-tracked with at the time. Here is the list of small things we could do to cleanup the source code and interface a little.

  • Rename "huber_scale_huber" parameter -> "huber_scale"
  • Get this to follow the -1 heuristic for using all CPU's
  • we should probably remove the get_ prefix from get_mutations_df and get_variants_df . get should only be for getter/setter operations
  • we should add method to output wide version of mutations df. This is really useful for many of the plots we make for the manuscript
  • make sure for all plotting functions (that it's appropriate) we have the R^2 option to show coefficient of determination.
  • remove the ipywidgets dependency and the fancy progress bars. They're annoying and unnecessary.
  • rename the ModelCollection.fit_models attribute -> ModelCollection.models_df
  • We could allow for singletons in the params dict passed to fit_models. It would make for a nicer interface
  • Let's do the kwargs thing here
  • Make the epistatic and activation function arguments to model a string instead of the function definition.
  • Allow output of Model.get_mutations_df() to output either wide, or tall formats.
  • Print more useful error message when fits fail in fit_models call
  • Use pytest fixtures to speed things up and make global test inputs more consistent
  • Make method for printing convergence trajectory for models.
  • Let's make sure condition names match a certain pattern, like that there's no "." in the condition name. That would clean up a lot of the altair plotting code.
@jgallowa07 jgallowa07 added the enhancement New feature or request label Apr 1, 2024
@jgallowa07 jgallowa07 self-assigned this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant