Resolve z-score discrepancy due to beads samples ordering #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a ton, @ksung25! I'm going to rebase this with some other changes that were just made, bump the versions for a new release, then I'll merge. |
jgallowa07
force-pushed
the
187-z-score-counts-discrepancy
branch
from
d3cd4c0 to
85863e9
Compare
Closed
jgallowa07
force-pushed
the
187-z-score-counts-discrepancy
branch
from
85863e9 to
bd75e60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use math.fsum to minimize rounding errors when summing CPMs over beads samples to determine peptide binning before computing Z-scores. Rounding errors can cause binning differences depending on the input order of beads samples, leading to different Z-score results.
I've made an example that demonstrates discrepant Z-scores if ran without the patch in this PR:
/fh/fast/matsen_e/ksung2/phippery_test_data/zscore_test.pyThis is tested with V1.13 VS57_Vir3_Jan2023_Z7 virscan.phip file.