Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of System.Text.Json #145

Open
dmrayt opened this issue Sep 27, 2021 · 4 comments
Open

Use of System.Text.Json #145

dmrayt opened this issue Sep 27, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@dmrayt
Copy link

dmrayt commented Sep 27, 2021

Hi!
Is there some plan to support System.Text.Json?

For Flurl, it's already possible with https://github.com/YellowLineParking/Appy.Flurl.

@matteobortolazzo
Copy link
Owner

Hi, no plan for it yet. I would like to keep Newtonsoft option available so people don't need to change their code too much. I haven't researched it yet

@dmrayt
Copy link
Author

dmrayt commented Sep 28, 2021

I didn't mean to replace Newtonsoft but add support for System.Text.Json as an option.

I don't know how much you use from Newtonsoft but the first step could be to use attributes from both library in your models.
e.g:

  [System.Text.Json.Serialization.JsonPropertyName("_rev")]
  [Newtonsoft.Json.JsonProperty("_rev")]
  public string Rev { get; set; }

@matteobortolazzo
Copy link
Owner

That's technically true, but I dont want to have both libraries there. I want NewtonSoft one to be optional with a second NuGet package. But I want to move to System.Text.Json as well

@matteobortolazzo matteobortolazzo self-assigned this Oct 12, 2021
@matteobortolazzo matteobortolazzo added the enhancement New feature or request label Oct 12, 2021
@matteobortolazzo
Copy link
Owner

So I did a bit of research, even if I want to implement System.Text.Json, it will take a huge amount of work. The NetwonSoft is used everywhere from deserialization of internal classes to options.

So I will keep this here not there will no updates in the near future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants