Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-742]: Added a note about the label of pr/issue if the subscription is specific to a label #839

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

Kshitij-Katiyar
Copy link
Contributor

Summary

Added a note to the subscription message post about the label of pr/issue if the subscription is specific to a label

Screenshots

Screenshot from 2024-09-25 17-58-16
Screenshot from 2024-09-25 17-58-25

Issue link

Fixes #742

How to Test

  • Setup the plugin
  • Create a subscription specific to a label
  • Check the subscription post after creating a PR/Issue with the same label

@Kshitij-Katiyar Kshitij-Katiyar added the 2: Dev Review Requires review by a core committer label Oct 22, 2024
@Kshitij-Katiyar Kshitij-Katiyar self-assigned this Oct 22, 2024
@wiggin77 wiggin77 added the 3: QA Review Requires review by a QA tester label Oct 22, 2024
@raghavaggarwal2308 raghavaggarwal2308 removed the 2: Dev Review Requires review by a core committer label Nov 24, 2024
Copy link

@arush-vashishtha arush-vashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested for label-specific subscriptions. LGTM

@raghavaggarwal2308 raghavaggarwal2308 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jan 6, 2025
@raghavaggarwal2308 raghavaggarwal2308 merged commit 803494b into master Jan 7, 2025
9 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-742 branch January 7, 2025 09:38
@raghavaggarwal2308 raghavaggarwal2308 added this to the v2.4.0 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscription posts related to labels should contain a string like "with label x"
4 participants