forked from react-bootstrap/react-bootstrap
-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
If we prevent default before applying the `onClick` function provided in props then we prevent elements from using the `event.preventDefault()` mechanics for anchors as buttons. For example in the Dropdown re-work this prevented me from having the Dropdown work when in a Nav since the toggle is an anchor. Yet that functionality should allow uses to prevent the Dropdown if they want in their own `onClick` handler. This will enable such a use case.
- Loading branch information
Showing
2 changed files
with
14 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters