From ff9a1cd10fad839250a10cd9c9b0db3fd6fe94a8 Mon Sep 17 00:00:00 2001 From: Julian Oes Date: Fri, 5 Apr 2024 10:20:48 +1300 Subject: [PATCH 1/2] action: add InvalidArgument result Required for set_actuator. Signed-off-by: Julian Oes --- protos/action/action.proto | 1 + 1 file changed, 1 insertion(+) diff --git a/protos/action/action.proto b/protos/action/action.proto index bda34714a..451fdf0f7 100644 --- a/protos/action/action.proto +++ b/protos/action/action.proto @@ -314,6 +314,7 @@ message ActionResult { RESULT_PARAMETER_ERROR = 11; // Error getting or setting parameter RESULT_UNSUPPORTED = 12; // Action not supported RESULT_FAILED = 13; // Action failed + RESULT_INVALID_ARGUMENT = 14; // Invalid argument } Result result = 1; // Result enum value From c61e60d48c1148cdb09b2256e1943d5d10640606 Mon Sep 17 00:00:00 2001 From: Julian Oes Date: Fri, 5 Apr 2024 10:28:17 +1300 Subject: [PATCH 2/2] action: note about set_actuator args Signed-off-by: Julian Oes --- protos/action/action.proto | 2 ++ 1 file changed, 2 insertions(+) diff --git a/protos/action/action.proto b/protos/action/action.proto index 451fdf0f7..5ca887d70 100644 --- a/protos/action/action.proto +++ b/protos/action/action.proto @@ -100,6 +100,8 @@ service ActionService { rpc Hold(HoldRequest) returns(HoldResponse) {} /* * Send command to set the value of an actuator. + * + * Note that the index of the actuator starts at 1 and that the value goes from -1 to 1. */ rpc SetActuator(SetActuatorRequest) returns(SetActuatorResponse) {} /*