Capability flags in camera information #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddatsko
changed the title
|
Oh one more thing: you need to make the mavsdk-proto submodule point to your branch that adds this definition (otherwise the CI will fail). When both PRs (this one and the mavsdk-proto one) are accepted, we can merge the mavsdk-proto one, you can update the submodule here, and finally we can merge this PR. Does that make sense? |
|
Yes, that makes sense. I will then wait for that one to get merged and will change the proto submodule here |
|
You can already point this PR to your MAVSDK-Proto branch, such that the CI passes here. Then it will have to be changed again once the MAVSDK-Proto PR gets merged 👍 |
…ate in proto repository
julianoes
force-pushed
the
flags_in_camera_info
branch
from
3423b1b
to
0eb1dea
Compare
julianoes
previously approved these changes
Apr 1, 2024
Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
|
ddatsko
added a commit
to ddatsko/MAVSDK
that referenced
this pull request
Aug 6, 2024
* Capability flags im camera information * Updated interface of camera capability flags setting to match the update in proto repository * Fixed code style * Merged tracking_server plugin into camera_server * Fix not registered callback for set_message_interval command * Fixed missing fourth argument in track_rectangle * camera_server: fixup conflicts * Update proto submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes together with the #329 PR in MAVSDK-Proto and adds the implementation for setting CAMERA_CAP_FLAGS in camera information by the user. This allows the user to set additional capabilities that cannot be determined automatically based on callback presence or so. For example, the implementation can not determine whether the CAMERA_CAP_FLAGS_CAN_CAPTURE_IMAGE_IN_VIDEO_MODE should be set, but this can be useful for some users. Another example of such a need is when the component also uses the tracking_server plugin for object tracking and the CAMERA_CAP_FLAGS_HAS_TRACKING_POINT or similar should be set in that case.
I didn't remove the functionality of determining four of the flags based on callback presence. This way, setting no flags will behave in exactly the same way as before