Skip to content
This repository has been archived by the owner on Jun 3, 2023. It is now read-only.

Generate historical market_data on the fly. #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zgohr
Copy link

@zgohr zgohr commented Feb 12, 2017

If historical market data isn't found during testing/benchmarking, generate it using the TradeKing API.

A better approach might be to just use the API for benchmarking. Is there a hard requirement that market data be stored locally?

@maxbbraun
Copy link
Owner

I actually did that first, but removed it because the data from the API gets less accurate (less granular) over time.

@zgohr
Copy link
Author

zgohr commented Feb 12, 2017

Alright. Is there anything you'd like me to do with this PR? I built it to fetch historical prices when benchmarking strategies that included other twitter accounts (@potus, etc.) It might still have value in that capacity.

@maxbbraun
Copy link
Owner

I'm not planning to merge this pull request, but thank you for the suggestion!

I suspect that the right way to make getting historical market data better would be to use an API that returns high-quality results, even for older data. Something like that would likely cost money.

@PhillGeorge
Copy link

Does it integrate with any trading api's such that trades can be automatically triggered once a pair/stock is mentioned by potus ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants