Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonize 'nan' vs empty strings vs ? #93

Open
3 tasks
WardDeb opened this issue Nov 22, 2022 · 0 comments
Open
3 tasks

harmonize 'nan' vs empty strings vs ? #93

WardDeb opened this issue Nov 22, 2022 · 0 comments

Comments

@WardDeb
Copy link
Member

WardDeb commented Nov 22, 2022

mismatching parkour dfs vs samplesheets give rise to empty strings (rather then nans) in the df. This can result in the issue below (though not on re-runs ?).

Todo:

  • harmonize 'empty' in dfs to np.NAN across entire workflow
  • have a check / issue warnings when samplesheet & parkour are not matching (especially in forward direction).
  • deal correctly with empties upon multiqc & email creation.
File "/home/pipegrp/src/github.com/maxplanck-ie/dissectBCL/src/dissectBCL/fakeNews.py", line 217, in multiQC_yaml                                                           
    reqDepth = float(                                                                  
ValueError: could not convert string to float: ''                                                                                                                             

Originally posted by @dkoppstein in #92 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant