Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about graph conv #1

Open
chenbys opened this issue May 26, 2020 · 1 comment
Open

about graph conv #1

chenbys opened this issue May 26, 2020 · 1 comment

Comments

@chenbys
Copy link

chenbys commented May 26, 2020

An interesting work, but I have some doubts about the graph conv.

The adj obtained at

DVBE/main.py

Line 133 in dd87981

adj = adj_matrix(nc)
seems a class_num*class_num identity matrix;
and, the adj will torch.mm with the FC features at
outputs = torch.mm(self.adj,outputs)
;
so, what's the meaning of adj, and how do their dims match?

@mboboGO
Copy link
Owner

mboboGO commented May 27, 2020

The graph operation is not used in this code version, thus the adj matrix generation code is incorrect. I will soon fix this issue in few days, and the correct adj matrix should not be an identity matrix.

In the correct version, the adj matix is ncnc dimensional, and outputs is ncC dimensional, where C is the feature channel.
Thus, their dims are matched for torch.mm(adj,output).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants