chore: Add flex_zone pages to Mercury screen requests #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalcora
reviewed
Nov 26, 2024
digitalcora
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Conditionally approving: I think we should have a controller test for this, to verify that A) it works as intended right now and B) we don't break Mercury screens in the future, since that kind of thing might otherwise slip past us in our own manual testing. It doesn't need a ton of detail, just that the flex_zone exists under the right circumstances.
cmaddox5
force-pushed
the
cm/add-flex-zone-to-data-response
branch
from
b64dd5a to
140e2e9
Compare
cmaddox5
force-pushed
the
cm/add-flex-zone-to-data-response
branch
from
140e2e9 to
8479f82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mercury asked for us to append all flex zone pages to each data request. This will allow them to make less requests and improve battery life. Because the layout is required to get the flex zone data, I decided to make an alternative to
get/2that works throughselect_variant/3with a differentthen_fn. I worry this might be a tad overcomplicated so happy to hear alternatives.