refactor: parse all elevator redundancy categories #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulJKim
reviewed
Dec 11, 2024
| %{"redundancy" => 1} -> | ||
| %__MODULE__{id: id, redundancy: :nearby} | ||
|
|
||
| %{"redundancy" => 2} -> |
There was a problem hiding this comment.
Category 2 should also be returning summary text as well shouldn't it? At least according to the task that this is a prerequisite for mentioned in the PR description.
There was a problem hiding this comment.
I'm conceiving of this module as purely an interface to the data in the spreadsheet — "rules" apart from the raw data, like "when the redundancy category is 2, always use this specific text" would be implemented in the widget generator. I decided to draw the line here because of the rule where the summary text for all categories changes if any of the "backup elevators" for a given elevator are down, which depends on data from outside the spreadsheet (active alerts).
PaulJKim
reviewed
Dec 12, 2024
Rather than only storing whether an elevator's redundancy category is "nearby", we now store all categories, including any associated summary text. This is a prerequisite for displaying redundancy summaries on the system-wide outages view. Also extracts this logic into a dedicated module which can be mocked for testing, removing the need for a separate fixture file.
digitalcora
force-pushed
the
cfg-backup-route-summary
branch
from
cf53232 to
db5a585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than only storing whether an elevator's redundancy category is "nearby", we now store all categories, including any associated summary text. This is a prerequisite for displaying redundancy summaries on the system-wide outages view.
Also extracts this logic into a dedicated module which can be mocked for testing, removing the need for a separate fixture file.