Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider aead::Aead as an alternative to (or building block for) Cipher #72

Open
tarcieri opened this issue Jan 27, 2020 · 4 comments
Open

Comments

@tarcieri
Copy link
Contributor

The aead crate provides abstractions for AEAD algorithms (including no_std-friendly ones) with several implementations including adapters for the AEAD algorithms in ring.

Aside from the rekey method, it seems like it's close to a drop-in replacement for the existing Cipher trait.

@mcginty
Copy link
Owner

mcginty commented Feb 6, 2020

Thanks for the issue @tarcieri!

These types should hardly be touched except for the rare cases where people need to implement their own providers of crypto algorithms not provided by snow itself, so I'm not sure if I can currently justify the extra dependency in my head, especially if only Cipher gets this treatment, and we don't also start relying on RngCore to replace Random, etc.

@fogti
Copy link
Contributor

fogti commented Mar 30, 2020

Currently, snow already depends on crates which depend on aead, so this wouldn't really change the amount of crates pulled in.

@tarcieri
Copy link
Contributor Author

There is one problem with using the aead crate's traits for Snow's purposes right now: they aren't object safe, but easily could be with some small changes.

@fogti
Copy link
Contributor

fogti commented May 30, 2020

that specific issue with aead is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants