Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate highness plugin functionality to core NCrystal #194

Open
tkittel opened this issue Sep 4, 2024 · 0 comments
Open

Migrate highness plugin functionality to core NCrystal #194

tkittel opened this issue Sep 4, 2024 · 0 comments
Labels
algorithms Issues related to physics algorithms enhancement plugins

Comments

@tkittel
Copy link
Member

tkittel commented Sep 4, 2024

Highness plugins developed by @ShuqiXu7, @nicriz, @marquezj, @dddijulio, et. al. should be reviewed for adoption into core NCrystal.

For the SANSND plugin, perhaps we could simply have a dedicated .ncmat file with the I(Q). Once NCrystal supports I(Q) for SANS of course.

For the magscat plugin, we simply need to add an optional section with the new parameters.

For the MD texture plugins we need to discuss, since it is useful for some applications, but does not implement a consistent cross section for off-axis neutrons. Perhaps integrate it but require a builtin '@CUSTOM_` section to activate?

Anyway, this is not super urgent, but would be a shame to drop these features. And it is hard to maintain them as separate plugins.

@tkittel tkittel added enhancement plugins algorithms Issues related to physics algorithms labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithms Issues related to physics algorithms enhancement plugins
Projects
None yet
Development

No branches or pull requests

1 participant