Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cross section curves w.r.t. references. #197

Open
tkittel opened this issue Sep 17, 2024 · 1 comment
Open

Test cross section curves w.r.t. references. #197

tkittel opened this issue Sep 17, 2024 · 1 comment
Labels
enhancement tests unit tests and CI setup

Comments

@tkittel
Copy link
Member

tkittel commented Sep 17, 2024

It would be super useful with a test which would (for all materials most likely) compare cross section curves with a reference, and only fail if they changed by more than some low tolerance (e.g. 1e-7). However, it would hopefully be easy to maintain since it should report:

  1. Any missing or new files.
  2. The difference for each file, as well as the worst difference seen.
  3. Also investigate per-component (e.g. inelastic, coh_elas, ...).

So when we would update something and expect small differences, it would be trivial to quickly look at the summary of changes, verify they are meaningful (possibly with a utility to show the plot differences), and ultimately run a script to update the values.

This would be both a great test, and easy to maintain with fewer false positives in failures.

@tkittel tkittel added enhancement tests unit tests and CI setup labels Sep 17, 2024
@tkittel
Copy link
Member Author

tkittel commented Sep 17, 2024

Scatter sampling would be harder, but those should be covered by making our MiniMC-based tests portable and apply them more widely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement tests unit tests and CI setup
Projects
None yet
Development

No branches or pull requests

1 participant