Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor function calling code by moving it into ToolManager or FunctionRegistry #40

Closed
szschaler opened this issue Apr 25, 2023 · 0 comments · Fixed by #193
Closed

Refactor function calling code by moving it into ToolManager or FunctionRegistry #40

szschaler opened this issue Apr 25, 2023 · 0 comments · Fixed by #193

Comments

@szschaler
Copy link
Contributor

szschaler commented Apr 25, 2023 •
edited
Loading

This is about moving the code for calling action functions (and probably for conversion of parameters) into ToolManager or even into the FunctionRegistry.

This depends on the refactoring in #34 being completed first, so that there actually is a function to move.
@szschaler szschaler converted this from a draft issue Apr 25, 2023
@barnettwilliam barnettwilliam moved this from Clean up before R1 to In Progress in Education Platform May 2, 2023
@barnettwilliam barnettwilliam moved this from In Progress to Clean up before R1 in Education Platform May 2, 2023
barnettwilliam added a commit that referenced this issue May 5, 2023
@barnettwilliam
Structural changes following review of issue #34, providing functions…
4f811dd 
… following the naming of: invokeActionFunction, resolve, convert, find, call. Added wrapper functions for functionality that will be relocated as part of issue #40.
@szschaler szschaler moved this from Clean up before R1 to Todo in Education Platform May 12, 2023
@barnettwilliam barnettwilliam moved this from Todo to In Progress in Education Platform Mar 12, 2024
barnettwilliam added a commit that referenced this issue Mar 12, 2024
@barnettwilliam
Moved tool functions and conversion function invocation to ToolsManag…
8678cf2 
…er and FunctionRegistry as part of #40
This was referenced Mar 12, 2024
Open
Merged
@barnettwilliam barnettwilliam linked a pull request Mar 12, 2024 that will close this issue
Refactor tool function calling code #193
Merged
@barnettwilliam barnettwilliam moved this from In Progress to In review in Education Platform Mar 12, 2024
barnettwilliam added a commit that referenced this issue Mar 22, 2024
@barnettwilliam
Moved tool functions and conversion function invocation to ToolsManag…
8935ef2 
…er and FunctionRegistry as part of #40
@github-project-automation github-project-automation bot moved this from In review to Done in Education Platform Mar 26, 2024
barnettwilliam added a commit to mdenet/educationplatform-docker that referenced this issue Mar 26, 2024
@barnettwilliam
Updated submodules to include fixes for: mdenet/educationplatform#40 …
8116843 
…refactor action function calling, mdenet/educationplatform#190 tests for ActivityValidator, mdenet/educationplatform#201 tests for EducationPlatformApp action function calling, mdenet/educationplatform#200 populate only required tool function parameters, mdenet/educationplatform#198 tests for EducationPlatformApp, and mdenet/platformtools#66 changed OCL tool language type to text.
@barnettwilliam barnettwilliam mentioned this issue Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Education Platform
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor tool function calling code mdenet/educationplatform
1 participant
@szschaler