Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parameterName parameter from convert #58

Open
barnettwilliam opened this issue May 11, 2023 · 0 comments
Open

Remove parameterName parameter from convert #58

barnettwilliam opened this issue May 11, 2023 · 0 comments

Comments

@barnettwilliam
Copy link
Collaborator

barnettwilliam commented May 11, 2023

Remove the parameter name from convert() and convertIncludingMetamodel().

The parameterName is added to the class returned by the promise of the convert function for the converted value. So when all of the action function's parameters resolve and the action function is ready to be invoked, the converted values can be mapped to respective parameter names for creating the request.

It is possible to refactor to remove parameterName because Promise.all preserves the order in which the promises are added so the resolved values match the parameter order the invokeActionFunction() creates. However, this requires #41 to be fixed otherwise when building the request additional optional parameters are inserted that won't match invokeActionFunction() parameter order exactly as is needed.

Originally posted by @barnettwilliam in #49 (comment)

@barnettwilliam barnettwilliam changed the title The parameterName is added to the class returned by the promise of the convert function for the converted value. So when all of the action function's parameters resolve and the action function is ready to be invoked, the converted values can be mapped to respective parameter names for creating the request. Remove parameterName parameter from convert May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant