Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ARM64 architecture. #113

Open
mdgreenwald opened this issue Mar 12, 2022 · 1 comment · May be fixed by #222
Open

Support ARM64 architecture. #113

mdgreenwald opened this issue Mar 12, 2022 · 1 comment · May be fixed by #222
Assignees
Labels
enhancement New feature or request

Comments

@mdgreenwald
Copy link
Owner

Currently the mozilla-sops-action is hard-coded to download the AMD64 binaries of the Mozilla/Sops project.

return util.format('https://github.com/mozilla/sops/releases/download/%s/sops-%s.linux.amd64', version, version);

return util.format('https://github.com/mozilla/sops/releases/download/%s/sops-%s.darwin.amd64', version, version);

With the rise of general ARM availability there is potential for the mozilla-sops-action to be run on an ARM instance. Currently if this were to occur, it would fail. Therefore it would be good to future proof the action for this scenario.

@mdgreenwald mdgreenwald added the enhancement New feature or request label Mar 12, 2022
@mdgreenwald mdgreenwald self-assigned this Mar 12, 2022
@moshest
Copy link

moshest commented Aug 15, 2023

I'm also needing this.

The action can automatically select the right binary using the runner.arch context variable.

@BradenM BradenM linked a pull request Jun 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants