Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark ShadowRoot.getSelection as not supported in Firefox or Safari and as non-standard #9434

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Mark ShadowRoot.getSelection as not supported in Firefox or Safari and as non-standard #9434

merged 1 commit into from
Mar 12, 2021

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Mar 11, 2021

Prompted by #9431 and
confirmed by mdn-bcd-collector results.

@foolip
Mark ShadowRoot.getSelection as not supported in Firefox or Safari
e9f3ab3 
Prompted by mdn#9431 and
confirmed by mdn-bcd-collector results.
@foolip foolip requested a review from Elchi3 March 11, 2021 23:14
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Mar 11, 2021
@foolip foolip mentioned this pull request Mar 11, 2021
Merged
Elchi3
Elchi3 approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this getSelection situation was already messy enough in the docs, but no, then comes Chromium with a non-standard implementation :D Thanks for your PR!

@Elchi3 Elchi3 changed the title Mark ShadowRoot.getSelection as not supported in Firefox or Safari Mark ShadowRoot.getSelection as not supported in Firefox or Safari and as non-standard Mar 12, 2021
@Elchi3 Elchi3 merged commit 9a19006 into mdn:master Mar 12, 2021
@foolip foolip deleted the firefox-safari-ShadowRoot-getSelection branch March 12, 2021 07:15
@foolip
Copy link
Contributor Author

foolip commented Mar 12, 2021

@Elchi3 it seems fine to me to just not document the non-standard variant beyond a short note, certainly a separate page seems unnecessary.

@Elchi3
Copy link
Member

Elchi3 commented Mar 12, 2021

I agree. I will not document the non-standard behavior. If it is standardized one day, we can add docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foolip @Elchi3