Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing mime type prefix #36094

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Fix missing mime type prefix #36094

merged 2 commits into from
Sep 29, 2024

Conversation

maths22
Copy link
Contributor

@maths22 maths22 commented Sep 28, 2024

Description

Fixes Windows ZIP MIME type to match actual values.

Motivation

It is helpful to know the full MIME type any time one is working with MIME types.

Additional details

It seems that 7d9eecb inadvertently removed the application/ prefix for the windows ZIP MIME type.

Related issues and pull requests

Issue introduced in #35211

It seems that 7d9eecb inadvertently removed the `application/` prefix for the windows ZIP MIME type.  This change restores this missing prefix.
@maths22 maths22 requested a review from a team as a code owner September 28, 2024 23:57
@maths22 maths22 requested review from Elchi3 and removed request for a team September 28, 2024 23:57
@github-actions github-actions bot added Content:HTTP HTTP docs size/xs [PR only] 0-5 LoC changed labels Sep 28, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@Josh-Cena Josh-Cena merged commit a6b00d0 into mdn:main Sep 29, 2024
8 checks passed
fiji-flo pushed a commit that referenced this pull request Oct 2, 2024
* Fix missing mime type prefix

It seems that 7d9eecb inadvertently removed the `application/` prefix for the windows ZIP MIME type.  This change restores this missing prefix.

* Fix linter issue

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants