Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF133 puts Document.caretPositionFromPoint() shadowroot to nightly #36910

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Nov 21, 2024

FF133 rolls back the shadow mode behaviour on Document.caretPositionFromPoint that was added as a parameter option in FF133 as tracked in #35702.

The option is now behind a pref that is set to be enabled in nightly/preview, as per https://bugzilla.mozilla.org/show_bug.cgi?id=1914596#c8. I've added BCD update in mdn/browser-compat-data#25177

This is a release note.

@hamishwillee hamishwillee requested a review from a team as a code owner November 21, 2024 23:48
@hamishwillee hamishwillee requested review from bsmth and removed request for a team November 21, 2024 23:48
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed labels Nov 21, 2024
Copy link
Contributor

Preview URLs

External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/133
Title: Firefox 133 for developers

@@ -59,6 +59,8 @@ This article provides information about the changes in Firefox 133 that affect d

#### Removals

- The [`options.shadowRoots`](/en-US/docs/Web/API/Document/caretPositionFromPoint#shadowroots) argument for passing {{domxref("ShadowRoot")}} objects to the {{domxref('Document.caretPositionFromPoint()')}} method has been withdrawn from the release. It remains available in the nightly release and is expected to re-release in future. ([Firefox bug 1914596](https://bugzil.la/1914596)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this?

Suggested change
- The [`options.shadowRoots`](/en-US/docs/Web/API/Document/caretPositionFromPoint#shadowroots) argument for passing {{domxref("ShadowRoot")}} objects to the {{domxref('Document.caretPositionFromPoint()')}} method has been withdrawn from the release. It remains available in the nightly release and is expected to re-release in future. ([Firefox bug 1914596](https://bugzil.la/1914596)).
- The [`options.shadowRoots`](/en-US/docs/Web/API/Document/caretPositionFromPoint#shadowroots) argument for passing {{domxref("ShadowRoot")}} objects to the {{domxref('Document.caretPositionFromPoint()')}} method has been withdrawn from the release.
This can be enabled by setting the `dom.shadowdom.new_caretPositionFromPoint_behavior.enabled` preference to `true`, which is only enabled in the Nightly release by default. ([Firefox bug 1914596](https://bugzil.la/1914596)).

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment to mention the flag, but leaving a +1 so you can merge when you've had a look. TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants