Add deprecated symbols to system colors #37129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotWoods
requested review from
chrisdavidmills
and removed request for
a team
github-actions
bot
added
Content:CSS
|
Preview URLs (comment last updated: 2024-12-09 11:02:29) |
chrisdavidmills
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
@NotWoods thanks for making these really useful changes!
Approving your work. While I was here, I also took it upon myself to add the missing full stops to the non-deprecated system color definitions, as it was annoying me ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added deprecated icon next to deprecated system colors.
Additionally added equivalent non-deprecated colors from the spec.
Motivation
When scanning through the page, it's easy to miss the "deprecated" header. Adding the trash can icon makes it more obvious these colors are deprecated, as well as find the alternatives.
Additional details
Related issues and pull requests