Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of alert() #7560

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Aug 3, 2021

Fixes #7553. Replaces alert() in the live sample by writing output into a div.

@wbamberg wbamberg requested a review from a team as a code owner August 3, 2021 19:23
@wbamberg wbamberg requested review from jpmedley and removed request for a team August 3, 2021 19:23
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/WindowOrWorkerGlobalScope/setTimeout
Title: WindowOrWorkerGlobalScope.setTimeout()
on GitHub

No new external URLs

@wbamberg wbamberg mentioned this pull request Aug 3, 2021
27 tasks
@sideshowbarker sideshowbarker merged commit ba7a6eb into mdn:main Aug 3, 2021
@wbamberg
Copy link
Collaborator Author

wbamberg commented Aug 3, 2021

@sideshowbarker , do you think this is a reasonable pattern to use more generally, for tackling #7566 ?

@sideshowbarker
Copy link
Collaborator

@sideshowbarker , do you think this is a reasonable pattern to use more generally, for tackling. #7566 ?

In general, appending to or updating some visible element in the document seems like it’d be most helpful for developers — but I know is some cases, that’s probably a lot more work than it’s worth

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
@wbamberg wbamberg deleted the issue-7553-setimeout-alert branch October 15, 2022 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with "WindowOrWorkerGlobalScope.setTimeout()": (short summary here please)
2 participants