Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of alert() in DOMException() #7698

Merged
merged 1 commit into from
Aug 8, 2021
Merged

Replace usage of alert() in DOMException() #7698

merged 1 commit into from
Aug 8, 2021

Conversation

AnilSeervi
Copy link
Contributor

Fixes portion of #7566

@AnilSeervi AnilSeervi requested a review from a team as a code owner August 8, 2021 05:18
@AnilSeervi AnilSeervi requested review from sideshowbarker and removed request for a team August 8, 2021 05:19
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/API/DOMException/DOMException
Title: DOMException()
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/exceptionmembers (url: /en-US/docs/Web/API/ExceptionMembers) does not exist
  • broken_links:
    • Can't resolve https://developer.mozilla.org/en-US/docs/Web/API/DOMException/code

External URLs

URL: /en-US/docs/Web/API/DOMException/DOMException
Title: DOMException()
on GitHub

No new external URLs

@teoli2003 teoli2003 merged commit 437b776 into mdn:main Aug 8, 2021
@teoli2003
Copy link
Contributor

Thanks!

@AnilSeervi AnilSeervi deleted the patch-2 branch August 8, 2021 05:51
Anurella added a commit to Anurella/content that referenced this pull request Aug 8, 2021
@Anurella
Merge branch 'main' of https://github.com/mdn/content into arrayFill
98a644d 
* 'main' of https://github.com/mdn/content: (156 commits)
  (CSS Layout: Positioning) - typographical improvements (mdn#7694)
  Added note about addition of new keywords for break-inside (mdn#7695)
  Update formdata and touchstart macros (mdn#7713)
  Corrected sentence in Streams API overview (mdn#7712)
  Fix broken link (mdn#7711)
  Replace SVGMatrix with DOMMatrix (mdn#7710)
  Removed example covered by other examples (mdn#7706)
  Remove last link to NameList (mdn#7708)
  Delete DOMObject (mdn#7701)
  Remove <dl> list for return value of DOMException() (mdn#7699)
  Fix broken links in Glossary (mdn#7692)
  Fix broken link to NSS/FAQ (mdn#7709)
  Update DOM intro (DOM is no more different in each browsers) (mdn#7705)
  Update Touch() contructor syntax (mdn#7702)
  Replace usage of alert() in File.name(mdn#7703)
  Replace usage of alert() in KeyboardEvent.metaKey(mdn#7704)
  Replace usage of alert() in DOMException() (mdn#7698)
  Remove unnecessary <code> tag (mdn#7697)
  Fix mixin example in Object.create() article (mdn#7631)
  Replace usage of alert() in EventListener (mdn#7690)
  ...
wbamberg added a commit to wbamberg/content that referenced this pull request Sep 10, 2021
@wbamberg
Merge remote-tracking branch 'upstream/main' into remove-alert-webapi
39001c6 
* upstream/main: (87 commits)
  Update formdata and touchstart macros (mdn#7713)
  Corrected sentence in Streams API overview (mdn#7712)
  Fix broken link (mdn#7711)
  Replace SVGMatrix with DOMMatrix (mdn#7710)
  Removed example covered by other examples (mdn#7706)
  Remove last link to NameList (mdn#7708)
  Delete DOMObject (mdn#7701)
  Remove <dl> list for return value of DOMException() (mdn#7699)
  Fix broken links in Glossary (mdn#7692)
  Fix broken link to NSS/FAQ (mdn#7709)
  Update DOM intro (DOM is no more different in each browsers) (mdn#7705)
  Update Touch() contructor syntax (mdn#7702)
  Replace usage of alert() in File.name(mdn#7703)
  Replace usage of alert() in KeyboardEvent.metaKey(mdn#7704)
  Replace usage of alert() in DOMException() (mdn#7698)
  Remove unnecessary <code> tag (mdn#7697)
  Fix mixin example in Object.create() article (mdn#7631)
  Replace usage of alert() in EventListener (mdn#7690)
  Fix link from Element to Document.querySelectorAll (mdn#7688)
  Replace usage of alert() in Window.find() (mdn#7686)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnilSeervi @teoli2003