-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pr-check-lint_content workflow will not failed when there are only EOL changes #25244
Comments
/cc @OnkarRuikar. Do you have any idea about this. Maybe the mdn/content repository also has this issue, is there any discussion on this :) |
😕 I couldn't see I think it's the missing |
Hey @OnkarRuikar, if you download the raw file corresponding to the commit (https://github.com/mdn/translated-content/blob/8eebac6a71750a410824ccda0919e9083e60ea3f/files/zh-cn/web/api/uievent/sourcecapabilities/index.md) directly, you would be able to see the |
I've made the required changes to the workflow but cannot test it using my Linux environment. I can make a commit with I don't understand how they managed to get the file with CRLF committed with the current settings. Let me know how to get a file with |
I can't reproduce this, let me get some information from the PR's author ^_^ |
He used Commit in your fork using |
I found the file (
files/zh-cn/web/api/uievent/sourcecapabilities/index.md
) in #25207 is using thecrlf
EOLs which will be replaced withlf
by prettier, see the workflow run: https://github.com/mdn/translated-content/actions/runs/12510390631/job/34901079183#step:10:62We need a solution to detect this error in PR.
Addition: the clean-up job is now handled by the daily markdownlint auto-cleanup (the cleanup PR for the above file: #25242)
The text was updated successfully, but these errors were encountered: