From 263f4a202b7a89df7a1a552983c3c96bc249aac0 Mon Sep 17 00:00:00 2001 From: Florian Dieminger Date: Wed, 30 Oct 2024 22:14:08 +0100 Subject: [PATCH] chore(deps)!: bump NodeJS from v18 to v20 (#12052) * chore(deps)!: bump NodeJS from Node v18 to v20 * chore(build): update deprecation warning --- .github/workflows/prod-build.yml | 2 +- .github/workflows/stage-build.yml | 2 +- .github/workflows/test-build.yml | 2 +- .nvmrc | 2 +- build/cli.ts | 2 +- package.json | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/prod-build.yml b/.github/workflows/prod-build.yml index 4261d7a5f38c..12e183273f89 100644 --- a/.github/workflows/prod-build.yml +++ b/.github/workflows/prod-build.yml @@ -354,7 +354,7 @@ jobs: for region in europe-west1 us-west1 asia-east1; do gcloud beta functions deploy mdn-prod-prod-$region \ --gen2 \ - --runtime=nodejs18 \ + --runtime=nodejs20 \ --region=$region \ --source=cloud-function \ --trigger-http \ diff --git a/.github/workflows/stage-build.yml b/.github/workflows/stage-build.yml index 0b5628ccaa3a..7eae27df7ad7 100644 --- a/.github/workflows/stage-build.yml +++ b/.github/workflows/stage-build.yml @@ -370,7 +370,7 @@ jobs: for region in europe-west1 us-west1 asia-east1; do gcloud beta functions deploy mdn-nonprod-stage-$region \ --gen2 \ - --runtime=nodejs18 \ + --runtime=nodejs20 \ --region=$region \ --source=cloud-function \ --trigger-http \ diff --git a/.github/workflows/test-build.yml b/.github/workflows/test-build.yml index 4039bbabf04b..95d986565212 100644 --- a/.github/workflows/test-build.yml +++ b/.github/workflows/test-build.yml @@ -250,7 +250,7 @@ jobs: for region in europe-west3; do gcloud beta functions deploy mdn-nonprod-test-$region \ --gen2 \ - --runtime=nodejs18 \ + --runtime=nodejs20 \ --region=$region \ --source=cloud-function \ --trigger-http \ diff --git a/.nvmrc b/.nvmrc index 3f430af82b3d..9a2a0e219c9b 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v18 +v20 diff --git a/build/cli.ts b/build/cli.ts index b59bc16eb1a8..311b33ec2bd5 100644 --- a/build/cli.ts +++ b/build/cli.ts @@ -487,7 +487,7 @@ program try { if (!options.nohtml) { console.warn( - "WARNING: Rendering index.html files as part of the build command is now DEPRECATED, and will no longer be supported in Yari v3. To resolve this warning, add the `-n` (`--nohtml`) option. For details, see: https://github.com/mdn/yari/pull/10953" + "WARNING: Rendering index.html files as part of the build command is now DEPRECATED, and will no longer be supported in Yari in the near future. To resolve this warning, add the `-n` (`--nohtml`) option. For details, see: https://github.com/mdn/yari/pull/10953" ); } diff --git a/package.json b/package.json index 0877408deded..ed021281d5d9 100644 --- a/package.json +++ b/package.json @@ -269,6 +269,6 @@ "webpack-node-externals": "^3.0.0" }, "engines": { - "node": ">=18.18.0" + "node": ">=20" } }