Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a general method for stdout separation #57

Open
A-CGray opened this issue Jun 14, 2021 · 3 comments
Open

Implement a general method for stdout separation #57

A-CGray opened this issue Jun 14, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@A-CGray
Copy link
Member

A-CGray commented Jun 14, 2021

Description of feature

Often if you want to be able to read the iteration printout of the pyAeroStructure MDA you have to suppress the iteration printing of the aero and structural solvers which can make it hard to diagnose problems. To help with this we should implement the ability to redirect the output from the 3 different solvers to 3 different files.

Previously, I implemented this in pyAeroStructure using multipoint's redirectIO method, but it was bespoke and not extensible to other combinations of solvers. You can see the implementation here

Potential solution

Instead we should add redirectIO functionality to our 3 solver types so they each can take a stdoutFile argument.

We should aim to implement something like _setSTDOut in the BaseSolver class so it can be inherited by each solver and then add in calls to it in the right places (e.g in __call__, evalFunctions etc) in each solver.

@A-CGray A-CGray added enhancement New feature or request help wanted Extra attention is needed labels Jun 14, 2021
@A-CGray A-CGray self-assigned this Jun 14, 2021
@A-CGray A-CGray changed the title Implemented a general method for stdout separation Implement a general method for stdout separation Jun 15, 2021
@marcomangano
Copy link
Contributor

Just bumping it up because we should take care of this some time soon

@A-CGray
Copy link
Member Author

A-CGray commented Aug 30, 2021

I very much agree, however I have quite a lot of TACS PR's on my plate at the moment, the nonlinear solver stuff in particular is gonna take a while. Can we assign someone else to this? It doesn't really require any prior knowledge of any of our code

@marcomangano
Copy link
Contributor

Yeah sure, I think you self-assigned just because of your previous attempt but I am not sure if we can use that branch, no worries

@akleb akleb mentioned this issue Oct 7, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants