MBS-8701: Fix version number in upgrade step #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh-csg
force-pushed
the
MBS-8701-Hotfix
branch
from
0d355d4 to
bdc1b7a
Compare
PhMemmel
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
CR done.
Tested:
- Installed v0.9.5.2, setup learningmap instance, verify everything works
- Upgrade to v0.9.6
- Crashes all pages like reported in Big Problem: Error reading the database after update to v.0.9.6 #91
- Check out hotfix branch
- Do update step
- Everything works again
Good analysis of the issue, fix is spot on.
Also wrapping the dangerous hook function code in a try-catch block is a good idea. Bad things can happen in few lines of code... :) and in this case will crash the whole moodle instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91