Create infinite autofill component #305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThaNarie
requested changes
Jan 23, 2024
| # InfiniteAutoFill | ||
|
|
||
| Uses the AutoFill to repeat children to fill the parent element in given axis. In addition to that | ||
| it adds the children one more time to the end of the list. This can be useful for example marquee's. |
There was a problem hiding this comment.
Suggested change
| it adds the children one more time to the end of the list. This can be useful for example marquee's. | |
| it adds the children one more time to the end of the list. This can be useful for example marquees or infinite carousels. |
| function DemoComponent() { | ||
| return ( | ||
| <div style={{ height: 1000, outline: '1px solid black' }}> | ||
| <InfiniteAutoFill> |
| /** | ||
| * Repeats children to fill the parent element in given axis. | ||
| */ | ||
| export function InfiniteAutoFill({ children, axis = 'x' }: InfiniteAutoFillProps): ReactElement { |
There was a problem hiding this comment.
Do we want to "copy" the default here? Making it undefined is enough IMO.
| ref: RefCallback<unknown>; | ||
| }; | ||
|
|
||
| type InfiniteAutoFillProps = { |
There was a problem hiding this comment.
Can use the AutoFillProps instead of copying them, so this will be in sync if the others are updated.
| ref: RefCallback<unknown>; | ||
| }; | ||
|
|
||
| type InfiniteAutoFillProps = { |
There was a problem hiding this comment.
Suggested change
| type InfiniteAutoFillProps = { | |
| type InfiniteAutoFillProps = ComponentProps<typeof AutoFill>; |
tworrisb
force-pushed
the
feature/create-infinite-autofill-component
branch
2 times, most recently
from
66510e9
to
09c9721
Compare
tworrisb
force-pushed
the
feature/create-infinite-autofill-component
branch
from
09c9721
to
168e305
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.