-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve: smooth walk #924
improve: smooth walk #924
Conversation
Seems that the walking broke, sometimes I can take few diagonal steps in a row, sometimes my character stops when taking turns for more time than he should. The issue with rendering from #918 still happens too. |
@nekiro note: I tested with 1098 and 1340, vsync with 144hz and no-vsync without limited fps |
Now the walk lags when turning, diagonals seem to be ok. |
Try out the walk, I think it's better than what you'll find in the main branch. About the shaking, I could only reproduce it by manually limiting the FPS, it doesn't happen with vsync. Since I rewrote a lot of things, I just need you to confirm that it's working as expected. We'll try to resolve this in another PR. |
Arrow walking seems ok, map click still "teleports" and there is weird lag after first step hexadia-client_gl_x64_89zMGPBToD.mp4 |
@nekiro OTClient.-.Redemption.2024-10-15.16-01-09.mp4try again, maybe I fixed it without realizing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, its working fine, it seems it was my bad with the step duration calculation (I got some custom changes and it conflicted)
No description provided.