Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dictionary support #583

Merged
merged 14 commits into from
Nov 27, 2024
Merged

Add dictionary support #583

merged 14 commits into from
Nov 27, 2024

Conversation

danFbach
Copy link
Contributor

Pull Request

Related issue

Fixes #483

What does this PR do?

  • Adds dictionary support
  • tests added and passing
  • code samples added

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@danFbach danFbach changed the title Add dictionary support 483 Add dictionary support #483 Nov 14, 2024
@curquiza curquiza self-requested a review November 14, 2024 15:55
@curquiza curquiza changed the title Add dictionary support #483 Add dictionary support Nov 27, 2024
@curquiza curquiza added the enhancement New feature or request label Nov 27, 2024
@curquiza
Copy link
Member

bors try

curquiza
curquiza requested changes Nov 27, 2024
View reviewed changes
.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
meili-bors bot added a commit that referenced this pull request Nov 27, 2024
@meili-bors
Try #583:
4be16dc
@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Nov 27, 2024

try

Build failed:

@curquiza
Copy link
Member

@danFbach
looks like the tests do not pass with you PR. Can you fix the tests?

@danFbach
Copy link
Contributor Author

okay, i see the issue. I needed to assign the Dictionary in SettingsWithDefaultedNullFields.
sending commit now.

curquiza
curquiza approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again @danFbach

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Nov 27, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit de4e10f into meilisearch:main Nov 27, 2024
4 checks passed
@danFbach danFbach deleted the add-dictionary-suppory-483 branch November 27, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.4] Support user-dictionary loading
2 participants
@danFbach @curquiza