Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generic exception MeilisearchException to throw more accurate Exception #719

Closed
wants to merge 1 commit into from
Closed

Update generic exception MeilisearchException to throw more accurate Exception #719

wants to merge 1 commit into from

Conversation

239yash
Copy link

@239yash 239yash commented Mar 28, 2024

Pull Request

Related issue

Fixes #678

What does this PR do?

  • PR updates the generic exception(MeilisearchException) throws from function to exact exception throws
  • Created a new exception MeilisearchUrlException for handling MalformedUrlException

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@curquiza curquiza changed the title updated generic exception(MeilisearchException) throws to exact exception Update generic exception MeilisearchException to throw more accurate Exception Mar 29, 2024
@curquiza curquiza added the breaking-change The related changes are breaking for the users label Mar 29, 2024
curquiza
curquiza reviewed Mar 29, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @239yash

thank you for your PR

Could you add integration tests to ensure the right exception are called in the right situation?

@239yash
Copy link
Author

239yash commented Mar 30, 2024

Hi @curquiza
Yes, I will add the integration tests too. Thanks

@curquiza
Copy link
Member

curquiza commented May 6, 2024

@239yash did you have a chance to work on it?

@239yash
Copy link
Author

239yash commented May 7, 2024

@curquiza hi, I am working on this. I will submit the PR by coming weekend. Thanks

@curquiza
Copy link
Member

curquiza commented Oct 3, 2024

Closing this for lack of activity. Feel free to re-open of course if you have time to work on it @239yash ❤️
I'm just doing some cleaning

@curquiza curquiza closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza left review comments

Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refining exception throws
2 participants
@239yash @curquiza