-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(form): add support for ChoiceType #88
Comments
Hello @Guikingone! I'm not a Symfony user, and no one is at Meili for the moment, so can you describe how the usage would change compared to the current one we have (cf our wiki)? Or is it just a feature addition? |
Hi @curquiza 👋🏻
It's a feature addition Advantages:
Disadvantages:
There might be some edge issues that I don't have in mind but IMHO, the feature could be interesting 🙂 |
As I'm not a Symfony user I cannot tell if it's worth it to add it, I mean if the pros neutralize the cons! 🙂 Maybe @codedge you have an opinion on it? 😇 Also, if someone around here is from the PHP/Symfony community and read this issue, feel free to comment and give your opinion. |
Hi, I recently began to use meilisearch (for now directly with the php lib) and for POC/basic usage I think this symfony lib could indeed leverage this kind of code but not activated by default, and let ppl activate it if needed Also, It could be great to have some others symfony components like messenger for async update, data collector to see the underlying MS requests, and maybe some views (twig/ux) logic to ease the frontend integration Those are just ideas on the go :) |
@94noni I fully agree for both Messenger support and DataCollector support 🚀 |
@Guikingone Anything that speaks against using your custom form type https://github.com/Guikingone/MeiliSearchBundle/blob/master/src/Form/Type/MeiliSearchChoiceType.php from being used here? I mean could you create a PR? |
Hi @codedge 👋🏻 For now, I prefer to talk about this idea and see if the bundle can benefit from it, If there's a consensus about the feature, I could easily create the PR to see if it fit technically 🙂 |
If you, as symfony users, think it's a good idea, let's start this! :) |
Description
Hi everyone 👋🏻
Is there any roadmap for a support of "search" in a form type?
What I mean by that is being able to create a custom form type that display a
ChoiceType
(or even in theSearchType
) which use theEngine
to display choices?Thanks again for the feedback 🙂
Basic example
Small example outside of this bundle: https://github.com/Guikingone/MeiliSearchBundle/blob/master/src/Form/Type/MeiliSearchChoiceType.php
The text was updated successfully, but these errors were encountered: