(bug-fix) Fix not adding first node in empty graph DB #1958
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes graph nodes not being created at all for an empty graph.
Done some debugging and found that in
graph_memory.py:102
the LLM chooses the NOOP tool despite a clear indication that a memory should be added:Further digging and #1879 (comment) showed that the LLM doesn't understand correctly
[]
as a lack of existing nodes.The change replaces
[]
with the word "None" which seems to work.Fixes #1906
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Used the sample graph code from the docs (https://docs.mem0.ai/open-source/graph_memory/overview) with an empty Neo4J DB at Aura:
Checklist:
I have added tests that prove my fix is effective or that my feature worksNew andExisting unit tests pass locally with my changesMaintainer Checklist