Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

購入申請作成APIを実装 #24

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

購入申請作成APIを実装 #24

wants to merge 2 commits into from

Conversation

CityBear3
Copy link
Contributor

Closes: #11

@CityBear3 CityBear3 requested a review from averak December 16, 2022 23:20
@CityBear3 CityBear3 self-assigned this Dec 16, 2022
averak
averak reviewed Dec 17, 2022
View reviewed changes
...c/rits/membership/console/paymaster/usecase/purchase_request/CreatePurchaseRequestUseCase.kt
* @param authentication 認証情報
* @param requestBody 購入申請作成リクエスト
*/
open fun handle(authentication: Authentication, requestBody: UpsertPurchaseRequestRequest) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[must] メール送信処理が抜けています。

  1. IAMにユーザリストを問い合わせ、PAYMASTERの管理者リストを取得
  2. 申請者 + PAYMASTERの管理者リストにメール送信

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averak averak averak left review comments

Assignees

@CityBear3 CityBear3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

購入申請作成API
2 participants
@CityBear3 @averak