Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset per-package variants if corresponding package is uninstalled #7

Open
memo33 opened this issue Oct 18, 2024 · 0 comments
Open

Comments

@memo33
Copy link
Owner

memo33 commented Oct 18, 2024

With the new per-package variant names group:pkg:variant, we should remove these package-local variants when the corresponding package is uninstalled.

In the unlikely case that another package makes use of the same variant, a new selection dialog would be triggered at the next update. (Usually, packages using foreign package-local variants should depend on the original package, which would avoid this.)

Additionally, if a variant is prefixed with a package name, the variantDescriptions should be taken from that package as a fallback. Currently, these are only taken from the package that makes use of the variants.

Moreover, there should be a way to add a text field to the variantDescriptions that is displayed in the selection dialog before all the variant names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant