Feat: locking l2 upgrade (DON'T MERGE) #542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the ci is failing because they removed regex parsing for version pragma in a recent foundry upgrade which is causing similar problems for other people. It also fails for dev branch at the moment. It should be fixed once this change is released: edit: they are fast :D the fix is released |
philbow61
approved these changes
Nov 21, 2024
bowd
requested changes
Nov 27, 2024
baroooo
changed the title
bowd
approved these changes
Nov 29, 2024
chapati23
reviewed
Dec 2, 2024
chapati23
reviewed
Dec 2, 2024
chapati23
reviewed
Dec 2, 2024
chapati23
reviewed
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates Locking Contracts to handle upcoming block.time change
Mainly changes the roundTimestamp() to have a forked implementation that uses different values to calculate week no for the blocks before and after l2 transition. Week numbers that return from roundTimestamp before and after should be continues and consistent.
Other changes
No
Tested
Unit and fork tests
Related issues