feat: add cCOP fork tests #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbow61
requested changes
Nov 4, 2024
There was a problem hiding this comment.
LGTM.
I added the cCOP exhchage on mainnet but alfajores tests are failing because of 2 reasons:
- oracle problems
- It looks like cCOP proposal wasn't executed on alfajores I assume the reason is that mu0Next was already executed on alfajores and the cCOP upgrade is causing problems with FixidityLib in 0.8
Therefore I would suggest we wait until cCOP is executed on testnets before merging this one
chapati23
force-pushed
the
feat/forkTestsCop
branch
from
f27aacd to
a27e906
Compare
chapati23
requested changes
Nov 5, 2024
There was a problem hiding this comment.
I rebased on top of the latest develop and had to fix some resulting compilation errors to get this to run.
Both alfajores and mainnet fork tests are failing for me rn, alfajores because of what @philbow61 said and 3 rate feeds being down rn
chapati23
approved these changes
Nov 5, 2024
philbow61
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add fork tests for $cCOP