Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: $GD resolved large reward issue #544

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: $GD resolved large reward issue #544

merged 1 commit into from
Nov 25, 2024

Conversation

RyRy79261
Copy link
Contributor

Description

This PR addresses the reward ratio reaching 0 if the reward is a large enough number

Tested

forge test ./test/unit/goodDollar/GoodDollarExchangeProvider.t.sol

Related issues

@RyRy79261 RyRy79261 self-assigned this Nov 21, 2024
Copy link
Contributor

@philbow61 philbow61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philbow61 philbow61 merged commit b14b3e6 into develop Nov 25, 2024
5 checks passed
@philbow61 philbow61 deleted the fix/gd-29 branch November 25, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants