From 3054430190d4ba4a5cf9b87a1a083b2f54199a61 Mon Sep 17 00:00:00 2001 From: Ryan Noble Date: Thu, 21 Nov 2024 11:53:17 +0100 Subject: [PATCH 1/2] fix: typo redundant casting --- contracts/goodDollar/BancorExchangeProvider.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/goodDollar/BancorExchangeProvider.sol b/contracts/goodDollar/BancorExchangeProvider.sol index 95391152..7b3ddfca 100644 --- a/contracts/goodDollar/BancorExchangeProvider.sol +++ b/contracts/goodDollar/BancorExchangeProvider.sol @@ -165,7 +165,7 @@ contract BancorExchangeProvider is IExchangeProvider, IBancorExchangeProvider, B /// @inheritdoc IBancorExchangeProvider function setReserve(address _reserve) public onlyOwner { - require(address(_reserve) != address(0), "Reserve address must be set"); + require(_reserve != address(0), "Reserve address must be set"); reserve = IReserve(_reserve); emit ReserveUpdated(address(_reserve)); } From a007f5232e8d81a4db12015cd3955152e688a2f3 Mon Sep 17 00:00:00 2001 From: Ryan Noble Date: Mon, 25 Nov 2024 15:40:53 +0100 Subject: [PATCH 2/2] fix: removed redundant cast --- contracts/goodDollar/BancorExchangeProvider.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/goodDollar/BancorExchangeProvider.sol b/contracts/goodDollar/BancorExchangeProvider.sol index 7b3ddfca..dd8113c2 100644 --- a/contracts/goodDollar/BancorExchangeProvider.sol +++ b/contracts/goodDollar/BancorExchangeProvider.sol @@ -167,7 +167,7 @@ contract BancorExchangeProvider is IExchangeProvider, IBancorExchangeProvider, B function setReserve(address _reserve) public onlyOwner { require(_reserve != address(0), "Reserve address must be set"); reserve = IReserve(_reserve); - emit ReserveUpdated(address(_reserve)); + emit ReserveUpdated(_reserve); } /// @inheritdoc IBancorExchangeProvider