Websocket connections do not get deleted

[showierdata9978]

When a client disconnects, there is a chance for the socket handler to not cause on close, so cloudlink is unable to delete the clients websocket connection.

In meower, this leads to always online (until restart) users or bots. Where the user or bot is unable to login to there account. Meower returns a internal error

When a socket is not deleted and you try to interact with it, it raises an error saying the client is closed.

Possible fix:
Catch the error and delete the client object and update ulist

[MikeDev101]

This is a design flaw with Cloudlink 3's underlying websocket framework.

We are continuing to make strides towards the CL4 port. With CL4 utilizing a radically different underlying websocket framework, this issue is of less concern.

On top of that, this issue is of extremely low probability of ever occurring, and (even if it does) you can always reconnect and try again.

Marking as won't fix, since this will be automatically rectified in the CL4 port.

[showierdata9978]

i have an account stuck in this state. CodeBot, try interacting with it. the only way to clear it is restarting the server

This is essentially like banning a user, but they cant be unbanned

the problem is that with the meower server, YOU CAN NOT RECONNECT.

[showierdata9978]

i was also planning on fixing this myself, should be clear because i self assigned

[JoshAtticus]

This is a design flaw with Cloudlink 3's underlying websocket framework.

Yeah, we know CL3 has issues, but that's no excuse not to fix them

We are continuing to make strides towards the CL4 port. With CL4 utilizing a radically different underlying websocket framework, this issue is of less concern.

Or will it, have you tested?

On top of that, this issue is of extremely low probability of ever occurring, and (even if it does) you can always reconnect and try again.

You can't just reconnect, because the session is still there

Marking as won't fix, since this will be automatically rectified in the CL4 port.

But you haven't tested, how would you know

(from @showierdata9978)
i was also planning on fixing this myself, should be clear because i self assigned

exactly this

Also you're only harming yourself and bot devs by not fixing this, more and more bot accounts and user accounts are getting glitched by this bug, Amethyst, the biggest bot project for Meower, had their account glitched, and when it was recreated with a new name, people thought it was an impersonation, and just stopped using it, meaning less activity, and less users.

[tnix100]

huh, I'm re-opening this because yeah it's an issue

but @JoshAtticus this will be rectified in CL4 port anyway because CL4 allows multiple clients from a single user and has a much more reliable underlying websocket server

[showierdata9978]

And il go fix it
RIGHT NOW

[JoshAtticus]

huh, I'm re-opening this because yeah it's an issue

but @JoshAtticus this will be rectified in CL4 port anyway because CL4 allows multiple clients from a single user and has a much more reliable underlying websocket server

But if it does happen in CL4, then accounts will still work, but you'll have a bunch of ghost connections that don't actually exist.

[tnix100]

huh, I'm re-opening this because yeah it's an issue
but @JoshAtticus this will be rectified in CL4 port anyway because CL4 allows multiple clients from a single user and has a much more reliable underlying websocket server

But if it does happen in CL4, then accounts will still work, but you'll have a bunch of ghost connections that don't actually exist.

well, yeah, it'll basically be a memory-leak but it won't affect anything

and if we spot a memory-leak then we'll need to fix it

[showierdata9978]

thats basicly what this is

[showierdata9978]

mb.py alerted me that this issue is still kicking around

https://github.com/meower-community/MeowerBot.py/blob/master/MeowerBot/Bot.py#L207

[tnix100]

This has been resolved.